Refactor ParamsBuilder to use setter instead of parameter #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the interface more consistent as "setBroaden" is also implemented as a setter.
schmengler
requested changes
Nov 14, 2017
| * @param string $attributeToReset | ||
| * @return $this | ||
| */ | ||
| public function setAttributeToReset($attributeToReset) |
There was a problem hiding this comment.
this empty method should not be necessary after suggested changes in integer-net/solr-base#8
There was a problem hiding this comment.
but solr-base is not changed yet? Tests now fail with
Fatal error: Declaration of IntegerNet\SolrSuggest\Query\SearchTermSuggestParamsBuilder::buildAsArray() must be compatible with IntegerNet\Solr\Query\ParamsBuilder::buildAsArray($attributeToReset = '') in /pipeline/source/src/SolrSuggest/Query/SearchTermSuggestParamsBuilder.php on line 16
There was a problem hiding this comment.
I had aborted work on integer-net/solr-base#8. Probably that's why, don't remember exactly at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the interface more consistent as "setBroaden" is also
implemented as a setter.
Required by integer-net/solr-base#8